PoW Crumble Undead Script

[ProphesyOfWolf]

Okay.. As everyone always asks before stuff like this.. Please, don't be mean 'bout how I did on this. Criticism is okay, as long as it is constructive..
Well, as this is my first script, it doesn't work right. Well, it says it compiled okay, but it just won't work. I'm not sure what I did wrong. I'm sure it's something small, but would you take a look at it, please?

{+-+-+-+-+-+-+-+-+-+-+-+-+-ProphesyOfWolf Presents-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#########################Undead Crumbler v 1.0#################################
## Lemme just give you a small story behind this script.. I was killing skellies
in Varrock Sewers when I though, "Hell, I should make a script for this thing..
It's such a pain in the ass clicking crumble undead so many times.." So, I
started making it. I hope you enjoy!###########################################

###############################Instructions####################################
### Go to the range/mage place in Varrock Sewers, directly across the Skeletons
and Ghosts (Go up the path north, go east, then north (There should be scorpions
next to you). I would not advise low levels to use this (Level 28 or lower), as
scorpions are very aggressive. You will need an earth staff (equipped), along
with air and chaos runes. You will need 2 air runes for every chaos rune, (and,
of course, a mage level of 39)so make sure to stop by your local rune shop, mmk?
                                  Good luck!
###############################################################################}
program PoWCrumbler;
{.include SRL/SRL.scar}
var
SkelColor,GhostColor,xg,yg,xsk,ysk: Integer;
KillSkel,KillGhost: Boolean;
procedure setup;
begin
 SkelColor:=6383720; //change if necessary
 GhostColor:=6776687; //again, change if necessary
 KillSkel:= True;//Do you want to kill Skeletons?
 KillGhost:= True;//Do you want to kill Ghosts?
end;
procedure clickcastfirst;
begin
 GameTab (7);
 MoveMouseSmooth(715, 450);
 ClickMouse(715, 450 , True);
end;
procedure clickcastchorus;
begin
 MoveMouseSmooth(715, 450);
 ClickMouse(715, 450 , True);
end;
procedure skeletonhit(State: Boolean);
 begin
 if (KillSkel = True) then
 if (findcolor(xg, yg, 7040116, 126, 141, 636, 474)) then
    begin
      ClickMouse(xg,yg,true);
    end else
 begin clickcastchorus;
end;
end;
procedure ghosthit(State: Boolean);
  begin
  if (KillGhost = True) then
  if (findcolor(xsk, ysk, 7831680, 126, 141, 636, 474)) then
     begin
       ClickMouse(xsk,ysk,true);
    end else
  begin clickcastchorus;
end;
end;
begin
end.

 

[ProphesyOfWolf]

I just noticed... It starts and then finishes instantaneously.. Very odd.. I'll try to mess around with it, but 'til then, would someone help?

 

[StarScreamer]

i see your problem, see this at the end of your script

begin
end.

that is where you tell the script what procedures to use and when.
like:

If (KillSkel = true)then
  begin
     Kill_Skeles;
  end;

If (KillGhost = true)then
  begin
    Kill_Ghosts;
  end;

something like that. need more help add me on msn [email protected]

 

[Town]

Since you've already included the SRL you should be using Mouse(); instead of movemouse or clickmouse.

Mouse(x, y, RandomX, RandomY, ClickLeftBoolean) is the same as movemouse + clickmouse.
MMouse(x, y, RandX, RandY) is the same as movemouse.

The difference is, they are not detectable in Runescape.

 

[StarScreamer]

had a play with your script this is how it should be

{+-+-+-+-+-+-+-+-+-+-+-+-+-ProphesyOfWolf Presents-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#########################Undead Crumbler v 1.0#################################
## Lemme just give you a small story behind this script.. I was killing skellies
in Varrock Sewers when I though, "Hell, I should make a script for this thing..
It's such a pain in the ass clicking crumble undead so many times.." So, I
started making it. I hope you enjoy!###########################################

###############################Instructions####################################
### Go to the range/mage place in Varrock Sewers, directly across the Skeletons
and Ghosts (Go up the path north, go east, then north (There should be scorpions
next to you). I would not advise low levels to use this (Level 28 or lower), as
scorpions are very aggressive. You will need an earth staff (equipped), along
with air and chaos runes. You will need 2 air runes for every chaos rune, (and,
of course, a mage level of 39)so make sure to stop by your local rune shop, mmk?
                                  Good luck!
###############################################################################}
program PoWCrumbler;
{.include SRL/SRL.scar}
const
  SkelColor = 6383720; //change if necessary
  GhostColor = 6776687; //again, change if necessary
  KillType = 'Ghosts'; //Ghosts/Skeletons

var
  xg, yg, xsk, ysk: Integer;

procedure clickcastfirst;
begin
  GameTab(7);
  Mouse(715, 450, 3, 3, True);
  Sleep(1000);
end;

procedure clickcastchorus;
begin
  Mouse(715, 450, 3, 3, True);
  sleep(500);
end;

procedure SkeletonHit;
begin
  if (findcolor(xg, yg, SkelColor, 126, 141, 636, 474)) then
  begin
    Mouse(xg, yg, 3, 3, true);
    Sleep(1000);
  end else
  begin
    clickcastchorus;
  end;
end;

procedure GhostHit;
begin
  if (findcolor(xsk, ysk, GhostColor, 126, 141, 636, 474)) then
  begin
    Mouse(xsk, ysk, 3, 3, true);
    Sleep(1000);
  end else
  begin
    clickcastchorus;
  end;
end;

begin
  setupSRL;
  repeat
    if (KillType = 'Skeletons') then
    begin
      clickcastfirst;
      SkeletonHit;
    end;

    if (KillType = 'Ghosts') then
    begin
      clickcastfirst;
      GhostHit;
    end;
  until (false)
end.

main loop works, and used const for declaring colors etc.