My Script isnt WORKING...

[apple tart72]

//This program is made by Apple Tart72â„¢
//I am one of the MOST NOOBIEST programmers in the world
//This is my first test
//Please Post comments+Help how to improve.That would be great!
//Again, I am the worlds most noobiest coder :)

program MineOre;

procedure GetToRunescape;
begin;
Wait(2000);
MoveMouseSmoothEx(378,184,20,40,45,25,20);
 Wait(50);
 ClickMouse(378,184,true);
end;
procedure LoginToRunescape;
begin
Wait(1000+random(500));
Sendkeys('USERNAME');
MoveMouseSmoothEx(369,341,20,40,45,25,20);
ClickMouse(369,341,true);
Wait(1000+random(500));
Sendkeys('PASSWORD');
Wait(1000+random(500))
MoveMouseSmoothEx(376,377,20,40,45,25,20);
ClickMouse(376,377,true);
end;
procedure WaitIfMembersNotMembers; //ANY HELP??
begin;
Wait(10000);
MoveMouseSmoothEx(398,369,20,40,45,25,20);
ClickMouse(398,369,true)
end;
procedure MoveToRock;
begin
Wait(3000+random(500));
MoveMouseSmoothEx(639,115,20,40,45,25,20);
ClickMouse(638,112,true);
Wait(5000+random(352));
end;
procedure ClickrocksandLOOP;
begin
repeat
 MoveMouseSmoothEx(296,184,20,40,45,25,20);
  Wait(200+random(500));
  ClickMouse(294,170,true);
  Wait(5000+random(89))
 MoveMouseSmoothEx(241,214,20,40,45,25,20);
  Wait(100);
  ClickMouse(264,205,true);
Wait(7000)//Lets Rock RESPAWN
until(false)//I gotta get better at that.
end;
begin;
GetToRunescape
LoginToRunescape
WaitIfMembersNotMembers
MoveToRock
ClickrocksandLOOP
end.

worts scripter ever

 

[x[Warrior]x3500]

real quick suggestions:

1. the ; after the "begin" command is just plain annoyin to me. sry

2. there are many times when u need a ; (like after "wait" a couple times)

3. when u r actually in the game, your wait commands MUST have random integers attached to it. Wait(100); will not work. easy way to get banned.

4. use images for clicking on (or colors) instead of clicking on a set point constantly. (look up a tut to learn how to do that effectively). that way, u can click on more than just 1 rock.
-EDIT- also, using colors/bitmaps u can "detect" when a rock is ready to mine. (like "repeat wait(100); until(findcolorstolerance...);" ) <-- real quick n easy code


5. actually use variables/constants, they are very effective


sry i dont have time to thoroughly go through your script. plz take these suggestions and hav fun.