Need PHP help

Trying to code a vBulletin hack that lets you ban several users at once:

Code:

if($_POST['do'] == 'ban')
{
    $vbulletin->input->clean_array_gpc('p', array(
        'username'    => TYPE_STR,
        'reason'    => TYPE_STR
    ));
    $usernames = $_POST['userlist'];
    $namearray = explode(" ",$usernames);
    $liftdate = 0;
    $reason = $_POST['reason'];
    if (!($vbulletin->userinfo['permissions']['adminpermissions'] & $vbulletin->bf_ugp_adminpermissions['ismoderator']))
    {
        if(!$canmassban)
        {
            print_stop_message('mbnopermission');
        }
    }
    $namearray[i] = $db->query_first("
        SELECT user.*,
            IF(moderator.moderatorid IS NULL, 0, 1) AS ismoderator
        FROM " . TABLE_PREFIX . "user AS user
        LEFT JOIN " . TABLE_PREFIX . "moderator AS moderator USING(userid)
        WHERE user.username = '" . $db->escape_string($vbulletin->GPC['username']) . "'
    ");
    $listlength = count($namearray);
    
    //$user = $db->query_first("SELECT user.*, IF (moderator.moderatorid IS NULL, 0, 1) AS ismoderator FROM " . TABLE_PREFIX . "user AS user LEFT JOIN " . TABLE_PREFIX . "moderator AS moderator USING(userid) WHERE user.username = '" . $db->escape_string($vbulletin->GPC['username']) . "'");
        
    //Gotta make  sure they exist/arent admin
    /*if (!$user OR $user['userid'] == $vbulletin->userinfo['userid'] OR is_member_of($user, 6))
    {
        print_stop_message('invalid_user_specified');
    }*/
    //Cant let mods ban each other    
    if (!($vbulletin->userinfo['permissions']['adminpermissions'] & $vbulletin->bf_ugp_adminpermissions['cancontrolpanel']))
    {
        if ($user['usergroupid'] == 5 OR $user['ismoderator'])
        {
            print_stop_message('no_permission_ban_non_registered_users');
        }
    }
    for($i = 0; $i < $listlength; $i++)
    {
        //The moment we've all been waiting for...
        $db->query_write("
            INSERT INTO " . TABLE_PREFIX . "userban
            (userid, usergroupid, displaygroupid, customtitle, usertitle, adminid, bandate, liftdate, reason)
            VALUES
            ($namearray[i][userid], 2, 0, 0, 1, '" . $vbulletin->userinfo['userid'] . ", TIMENOW, $liftdate, $reason)
        ");


    }
}

The error I get is:

Code:

Database error in vBulletin 3.6.7:

Invalid SQL:

            INSERT INTO userban
            (userid, usergroupid, displaygroupid, customtitle, usertitle, adminid, bandate, liftdate, reason)
            VALUES
            (->userid, 2, 0, 0, 1, '1, TIMENOW, 0, test);

MySQL Error  : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '>userid, 2, 0, 0, 1, '1, TIMENOW, 0, test)' at line 4
Error Number : 1064
Date         : Sunday, September 2nd 2007 @ 04:06:52 PM
Script       : http://localhost/modcp/massban.php?do=ban
Referrer     : http://localhost/modcp/massban.php?do=prepare
IP Address   : 0.0.0.0
Username     : Admin
Classname    : vB_Database

Any idea how to fix it :S

 

smr sorry for spamming but would you help me out with my security settings or could you reccomend a mod that could??

 

Code:

            INSERT INTO userban
            (user.userid, user.usergroupid, user.displaygroupid, user.customtitle, user.usertitle, user.adminid, user.bandate, user.liftdate, user.reason)

Replace that one line with that. I think that should work. If it doesn't it might be something else.

 

You forgot the $ in TABLE_PREFIX.

 

Thanks guys, and I just realized that I put the namearray thing OUTSIDE the for loop...

Gosh I'm an idiot lol.