Nontitle's Al Kharid SilverCrafter (Not Yet Done)

A long time ago, before SRL was out, I tried to make this same script, but had so much trouble with randoms and changing colors that i just decided to give up.

When I found out about SRL, I was very excited. I tried making it again, and so far it only took me 4 days. At this point in time, it is only the barebones of what i want, and it doesn't handle randoms, the gas in the mines, or the pick head falling off, so I put a warning at the top of the script.

-=-What It Does-=-
For this script to work, you have to start in the Al Kharid bank (anywhere is fine) with a Pickaxe wielded and a Saradomin Symbol Mould in your first inventory (as long as it isn't in the second or last slots, it should be fine). Drag the crosshair to the RS window and begin, then it will do it's magic.

It will start at the bank, and move it's way up to the silver in the mining pit. Once it reaches the silver, it will mine until the inventory is full. When that happens, it will maneuver it's way to the furnace and smelt the silver into bars. Once that's done, it mould's them into saradomin symbols and go back to the bank and store them there.

-=-Known Problems-=-

-Everything. This is not done yet, so don't expect it to work perfectly. Although if you watch it and stop it when randoms happen, you should be fine.

-Finding The Mining Symbol. When you first run the script, it will move up to the mine, but it will get stuck saying "Looking for Mining". This means it's looking for a color on the minimap of the mining symbol. I kinda screwed around with the tolerance too much and now it isn't working that well. If this happens, just stop the script, move to the silver patch in the mine, set the Loc to 2 (in configuration), and restart it, and it should get back to work.

-=-Download Links-=-
I have it in two formats: Colorful HTML and just normal SCAR Pascal text.

HTML: http://www.nxtitle.net/SilverCrafter/AlKhSilverCrafter.html
SCAR: http://www.nxtitle.net/SilverCrafter/AlKhSilverCrafter.scar

Just a reminder, but make sure you have the latest SCAR and SRL libs when you use this.

-=-More Information-=-
I am mainly posting this here if anyone wants to help out with this script. Also, if it helps at all, here is some information with the Loc Numbers:

0 - Very First Script Run. To use this, start at the Al Kharid bank with a pickaxe equipped and a Holy Mould in the 1st inventory spot.

1 - Walking to Mine. This is mainly used only by the script, and it isn't a good idea to start with this. I will soon get the script to "resume" walking if you stopped halfway between the bank and the mine. Until I get this script working well (or better than now), don't use this one.

2 - Mining Silver. To use this, start at the southmost silver patch in the mine, close enough so that you can see the silver in the main view. Here, it uses SRL to detect randoms, but it doesn't do anything about gas on the rocks or your pick head falling off.

3 - Walking Back. This is another Loc mainly used just by the script to continue. Read #2. If you have to use this one, though, start at the silver patch.

4 - Beginning smelting. To use this, start in the furnace room in lower Al Kharid, with a Holy Mould in your first inventory spot and silver ore in all the other spots. This one will smelt all of your silver ore into silver bars, but beware that this part doesn't detect randoms.

5 - Holyizing. To use this, start in the furnace room in lower Al Kharid with a Holy Mould in your first inventory spot and silver bars in the rest of the spots. This one moulds all the bars into Holy Symbols. This part doesn't detect randoms either.

6 - Back to Bank. To use this, start in the furnace room with the Holy Symbols in your inventory. This will walk back to the bank from the furnace room. That's all.

7 - Holy Store. To use this, start in the Al Kharid bank with the Holy Symbols in your inventory. This will open the bank using the SRL function OpenBankQuiet (thank you WT for making this function!), then store the made Holy Symbols into your bank, so you can either string them or sell them later. This pretty much finishes the loop, and starts back up at #1.

This was also posted at SRL forums, but i know i will get more replies and help from sythe.org.

 

Sleep(100);

I reccommend using Wait() instead of Sleep(). Also put in random timing like Wait(500 + Random(500)); Use random timing for SleepAndMoveMouse, too.

Setup more procedures at the beginning of the script instead of having a 500 line main loop. That will make things much more simple in the future. Your standards are decent.

You're obviously a good scripter but some small touch ups would help you and users in the future. Such as declaring your players as a procedure instead of having it smack in the middle of the script, then just calling on that procedure later. Good luck

 

Wow, thank you for the thorough review. I appreciate it.

Yeah, what I'm thinking of doing is having each step have it's own procedure instead of using an if statement for each. That's what I did last time, and it cleaned things up quite nicely. As for your suggestion with the random timing with SleepAndMoveMouse and Wait, that's a very good idea. It will be the next thing I work on.

A couple other things I have planned for this script is to make it work with more than one player, and to use a form to show the reports instead of the SCAR window, so that there's more space for the runescape client, but I won't be doing those for a while.

Thank you for the support, and I hope this turns out well.

-Keith